Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate code coverage and add icon to README.md Issue #3

Closed
wants to merge 8 commits into from

Conversation

Cormwww
Copy link

@Cormwww Cormwww commented Oct 9, 2024

I have finished the coverage report and added a badge to the read.me file after an embarrassing amount of time trying to figure out how to use rust.

@lyrakisk
Copy link
Owner

lyrakisk commented Oct 9, 2024

Hi, thank you for offering your help on this! Unfortunately, the current PR doesn't solve the problem at hand. I can give you some pointers:

  • There is no need for a new rust.yml file, as the project already has ci.yml which runs the cargo tests
  • At the moment, I see you hardcoded the coverage icon, so it will always display 35%, no matter what the real code coverage is. We don't want that. What we want, is to:
    • generate a code coverage report after running the tests
    • use this information to generate an icon that shows the real code coverage.

@lyrakisk lyrakisk self-requested a review October 10, 2024 10:39
@Cormwww
Copy link
Author

Cormwww commented Oct 11, 2024

I think now the code should work and you only need to run a coverage test for the badge to work in the readme file.

@lyrakisk
Copy link
Owner

Hey, I'm closing this PR, as I don't have enough time to guide you through the required changes.

@lyrakisk lyrakisk closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants